search

patsplat / plist

All-purpose Property List manipulation library
http://www.rubydoc.info/gems/plist
MIT License
306 stars 71 forks source link

Support custom indent string #44

Closed masolin closed 7 years ago

masolin commented 7 years ago

XML doesn't need to use tab as indent. Removing indent (by supporting custom indent) could be useful if we want to minimize the size of plist.

patsplat commented 7 years ago

Thanks for the PR! With a test case!

Fix the syntax error please.

masolin commented 7 years ago

@patsplat Just fixed it. Thanks for the prompt reply.

mattbrictson commented 7 years ago

@masolin Could you also add an entry to the CHANGELOG just below the Your contribution here! line? Then I think this PR will be good to go. Any other concerns, @patsplat?

masolin commented 7 years ago

Thanks @mattbrictson, I added some description to CHANGELOG and README.

mattbrictson commented 7 years ago

Looks great. Thanks! 🙇