search

patstockwell / vim-monokai-tasty

VIM Colour scheme
390 stars 51 forks source link

Monokai Pro variant #16

Closed ghost closed 5 years ago

ghost commented 5 years ago

Can you make a copy of the vim version based on the updated Monokai Pro colors?

6a94a056f6a649c5b30ebb3f9ffc5995704d289f

It is available for Sublime

I have extracted the color codes, but can't incorporate them well.

Thanks!

patstockwell commented 5 years ago

Hi @duhok1, I used monokai pro as a base when I started this theme. You can see the hex colour codes I settled on here: https://github.com/patstockwell/vim-monokai-tasty/blob/master/colors/vim-monokai-tasty.vim#L24-L29

Is there something that I missed? What do you think is different about vim-monokai-tasty that you want changed?

RCMainak commented 5 years ago

Hey @patstockwell, not sure should I put it here or create a new issue. I would like to see some enhancement for javascript arrow functions. Let me give you an example in the following screenshots,

Sublime Text with Monokai Screenshot at 2019-04-15 11-44-10

Vim with vim-monokai-tasty Screenshot at 2019-04-15 11-43-48

Thanks for the great work.

patstockwell commented 5 years ago

Hi @RCMainak,

Thanks for taking the time to give me some feedback! From the picture, I'm guessing you're pointing out the colour of the identifier 'arrowFunc'. You've picked up on something I've been trying to fix for a while. The short answer is, I don't think I can fix this yet. If I make the variable name green, then all variable names will be green, regardless of whether they are arrow functions or not.

Unfortunately, there aren't currently and identifiers which separate variables that are arrow functions, and variables for other data types.

In VIM, the job of matching and identifying grammar from a language is done with a syntax file. It uses Regex to parse and identify different parts of the language (eg. keywords, semicolons, etc). The job of highlighting is simply to give colours to each of the syntax groups. vim-monokai-tasty only takes exisiting highlight groups and gives them a colour. You'll notice in the README that I recommend extra plugins. Some of these are syntax files which identify more parts of the language for us. Unfortunately, nobody has figured out how to differentiate between an arrow function variable and normal variables.

If you can come up with a Regular expression that differentiates variables, I'd love to incorporate it!