Uncaught SyntaxError: Unexpected token <

ryanaltvater commented 6 years ago

After running gulp patternlab:version, I am using Pattern Lab Node- Gulp Edition v3.0.0-alpha.5 on Mac as-is right out of the box without any modifications.

Expected Behavior

Run gulp patternlab:serve without errors

Actual Behavior

Run gulp patternlab:serve with errors

screen shot 2017-12-18 at 4 58 25 pm

Steps to Reproduce

Run gulp patternlab:serve
Open the console tab in Chrome DevTools for errors

andeersg commented 6 years ago

I have noticed the same with a completely fresh download from this repo.

nrooban commented 6 years ago

I too getting this. also in windows

bmuenzenmeyer commented 6 years ago

I think I have this resolved with the latest code on dev of patternlab-node but I have yet to released it.

In the meantime, I'd check out the latest stable Edition found here: https://github.com/pattern-lab/edition-node-gulp/releases

zookee1 commented 6 years ago

Hej @bmuenzenmeyer, we are facing the same issues. Is there an approx. release date for 3.0 or the alpha-6?

Cheers

bmuenzenmeyer commented 6 years ago

@zookee1 It's done when https://github.com/pattern-lab/patternlab-node/milestone/22 is done.

I'll ship alpha.6 when it's more stable. If I shipped it now we'd be swapping out the issue mostly reported here (different than the OP's issue, actually) with issues about pattern parameters. The async work has been a massive disruption in the codebase. I'm trying to be as transparent as possible with these releases - keep the reports coming. If you find something that is already reported, a 👍 is more valuable to me than a "me too" comment.

zookee1 commented 6 years ago

@bmuenzenmeyer thanks for the clarification! :)

bmuenzenmeyer commented 6 years ago

Please upgrade @pattern-lab/patternlab-node to 3.0.0-alpha.6 and report back findings

samsmithnz commented 6 years ago

Also seeing this, as well as a favicon.ico issue, when generating and setting up in IIS (on Windows) postreleaseerrors

hhsl commented 6 years ago

Patternlab 3.0.0.-alpha.6 works like a charm, upgrading was as easy as cleaning up and upgrading our build scripts to Gulp4. Thanks!

Unfortunately the styleguide is making some problems, basically I can confirm @samsmithnz report. The index of the styleguide tries to import a bower_component which is not inside of the dist folder. Another problem is "Uncaught ReferenceError: config is not defined at index.html", referencing this line, for example when clicking View All of a molecule.

Currently we have "@pattern-lab/styleguidekit-assets-default": "^4.0.0-alpha.2" and "@pattern-lab/patternlab-node": "^3.0.0-alpha.7" installed as our project dependencies.

mearleycf commented 6 years ago

I'm still seeing this issue in v3.0.0-alpha.7.

bmuenzenmeyer commented 6 years ago

Trying to get a handle on this issue which is covering a lot of ground...

[X] [object Promise][object Promise][object Promise] - upgrade to latest @pattern-lab/patternlab-node alpha
[X] classList.min.js (according to git, removed in@pattern-lab/styleguidekit-assets-default@4.0.0-alpha.2. also double checked as part of latest @pattern-lab/styleguidekit-assets-default
[X] Favicon - open a separate issue if this is still a thing
[X] "Uncaught ReferenceError: config is not defined at index.html", referencing this line, for example when clicking View All of a molecule. - open a separate issue if this is still a thing
[ ] Uncaught SyntaxError: Unexpected token < what this issue pertains to. Troubleshooting continues

bmuenzenmeyer commented 6 years ago

Please try again with https://github.com/pattern-lab/edition-node-gulp/releases/tag/v2.0.0-alpha.2

samsmithnz commented 6 years ago

There is a lot going on here, I had to jump over to the WebPack version to find a solution that worked. The WebPack version seems to be stable, with more recent releases as a bonus. Note that the favicon issue seems to be a problem over there too, (but is easy to fix).

hhsl commented 6 years ago

@samsmithnz the webpack edition is using patternlab-node-2, not 3.

@bmuenzenmeyer most of the bugs seem to be solved by the alpha releases, thanks!

As far as I know only these problems occured :

clicking on "View All" of an Atom Folder results in TypeError: document.getElementById(...) is null in patternlab-viewer.js:1363
Pseudopatterns still have all the same data.

Should I open a new issue for this, especially for the patternlab-viewer.js of the styleguidekit-assets-default?

samsmithnz commented 6 years ago

@hhsl fair comment, but if I'm using Github properly (and it's likely I'm not), the last stable 2x release for the Gulp version was in 2016. https://github.com/pattern-lab/edition-node-gulp/releases/tag/v1.3.4. Did I miss something? I'm new here, and I'm finding the versioning challenging to get straight.

hhsl commented 6 years ago

You're absolutely right @samsmithnz, it is confusing. I just tried to clarify that the webpack-edition is running with different versions than the problems described in this issue.

bmuenzenmeyer commented 6 years ago

@samsmithnz

fair comment, but if I'm using Github properly (and it's likely I'm not), the last stable 2x release for the Gulp version was in 2016. https://github.com/pattern-lab/edition-node-gulp/releases/tag/v1.3.4. Did I miss something? I'm new here, and I'm finding the versioning challenging to get straight.

You're using Github just fine. 👍

Pattern Lab Editions are pre-packaged sets of the different modules that make up the entire working product. We call this the ecosystem.

The reason this repo can appear stale is because it's actually quite stable - with most of the work being done within the patternlab-node core. I hope that helps clear things up a bit.

Please continue to use Pattern Lab and report your findings. If you have time to help, even better!

pay-dro commented 6 years ago

After upgrading to the latest versions of @pattern-lab packages, issues continue. These are the versions in use:

@pattern-lab/edition-node-gulp 2.0.0-alpha.5
@pattern-lab/patternengine-node-mustache 2.0.0-alpha.2
@pattern-lab/patternlab-node 3.0.0-alpha.8
@pattern-lab/styleguidekit-assets-default 4.0.0-alpha.3
@pattern-lab/styleguidekit-mustache-default 4.0.0-alpha.1

Console error on load:

When clicking View All link from any pattern sub-type in the nav:

Glad to provide further details.

Seanom commented 6 years ago

Sorry I realised that this issue should be over here https://github.com/pattern-lab/patternlab-node/issues/835

I'm still getting this using 3.0.0-alpha.11

I'm using the starterkit-mustache-demo just in case that makes a difference?

pattern-lab / edition-node-gulp