pattern-lab / edition-node-gulp

ARCHIVED - The gulp wrapper around patternlab-node core, providing tasks to interact with the core library and move supporting frontend assets.
MIT License
279 stars 111 forks source link

Bower component not generated in windows #85

Closed arianjinx closed 8 years ago

arianjinx commented 8 years ago

I am using Pattern Lab Node- Gulp Edition v1.3.2 on Windows.

Expected Behavior

Bower component in /styleguide should be generated

Actual Behavior

Not generated and resulting 404 on home

Steps to Reproduce

Run all just like documentation tells in Windows 7

bmuenzenmeyer commented 8 years ago

I haven't run PL Node on Windows 7 in a long long time, but can confirm that this is working on Windows 10 against a copy of this repo.

image

What version of node are you running? node - v

bmuenzenmeyer commented 8 years ago

Update 1: I tested this tonight and am getting a ton of 404's on the client - which is not expected.

Investigating.

Update 2: This entire task seems to not be working all of a sudden:

gulp.task('pl-copy:styleguide', function(){
  return gulp.src(path.resolve(paths().source.styleguide), '**/!(*.css)')
    .pipe(gulp.dest(path.resolve(paths().public.root)))
    .pipe(browserSync.stream());
});

In addition to bower_components, fonts and js directories are likewise not copied.

Update 3: https://github.com/gulpjs/gulp/issues/1842

bmuenzenmeyer commented 8 years ago

@arianjinx a fix for this is now on the dev branch. will go out with next release

arianjinx commented 8 years ago

Hello thank you @bmuenzenmeyer sorry i just read the update, nice 😆 . I managed to have some temporary fix by changing styleguide path to this (adding cwd). return gulp.src(path.resolve(paths().source.styleguide, 'styleguide/**/!(*.css)'), { cwd: path.resolve(paths().source.styleguide, 'styleguide') }) Although it breaks gulp and needs to restart sometimes, but it's okay.

spuz commented 8 years ago

Sorry to say this issue is still unresolved for me. I am running Windows 10, Node v6.8.1, npm v3.10.9, gulp-cli 1.2.2, and gulp v4.0.0-alpha.2

Steps to reproduce:

  1. clone repo
  2. run npm install
  3. run gulp pl-copy:styleguide

This results in an empty folder dist in public/styleguide/. If I run gulp pl-copy:styleguide-css the folder structure looks like this public/styleguide/css/dist/ whereas dist is empty too.

bmuenzenmeyer commented 8 years ago

https://github.com/pattern-lab/edition-node-gulp/releases/tag/v1.3.4 should resolve this - would appreciate independent verification!

spuz commented 8 years ago

I hereby confirm: it is working as expected. Thank you very much!