Organize assets into _assets or _content

pattern-lab / edition-node-gulp

ARCHIVED - The gulp wrapper around patternlab-node core, providing tasks to interact with the core library and move supporting frontend assets.

MIT License

279 stars 111 forks source link

Organize assets into _assets or _content #98

Closed ninjasort closed 6 years ago

ninjasort commented 7 years ago

Hello,

It's not clear at first that the css, images, fonts, js folders are used within the _patterns through json files. It's a really great concept, but any way they could be grouped into a _assets or _content folder which would be consistent with the other folder names?

This might make it easier to reference the files in the json as well instead of using ../../. It would look a lot cleaner as well.

ninjasort commented 7 years ago

Looks like you can set this in the configuration. Didn't see that. https://github.com/pattern-lab/patternlab-node/wiki/Configuration

ninjasort commented 7 years ago

Looks like the npm rune postinstall adds these files to the root directory when run. Doesn't seem to be listening to the config. Any thoughts?

bmuenzenmeyer commented 6 years ago

postinstall you refer to is probably adding a starterkit, which adheres to this default structure: https://github.com/pattern-lab/patternlab-node/wiki/Importing-Starterkits

so if you change it, then install a starterkit, it will basically copy them back into location.

I could see this mechanism being improved in the future to

[ ] copy to what the user has mapped
[ ] not automatically install starterkits in postinstall

that second point is being addressed as part of 3.0 work