pattern-lab / patternengine-node-react

ARCHIVED - The React engine for Patternlab/Node
MIT License
50 stars 10 forks source link

Be able to resolve arbitrary modules #1

Open geoffp opened 8 years ago

geoffp commented 8 years ago

We should able to provide any mapping we want of module names requested in es2015 syntax to modules delivered to the code. The first step should be registering component-patterns as pattern partials so that component-patterns can include each other with an import and JSX syntax.

Syntax options

We may or may not able to support more than one of these.

One module per pattern, native naming

import Button from 'button';

import Button from 'atoms';

import AtomsButton from 'atoms-button';

We need to put something on the rendered pattern page to enable runtime execution of components, which is a must.

Bundle everything together on the pattern page with Webpack

This feels to sort of brute-force-y to me, but it could work.

I'm currently drawn to this one.

bramsmulders commented 7 years ago

Hi @geoffp, long time since there has been worked on this. Here in out company we're very interested in a react engine for patternlab where we could share the react templates with our backend system.

Were currently working in a fork to make this possible. Do you have any preference how you wanted to build this?

geoffp commented 7 years ago

@bramsmulders - for now, I'd like to make module resolution as flexible as we can without creating too many ambiguities, because I suspect every user will have their own preferences. This thing you pointed out looks very promising.

I'm also okay with the current practice of creating a module bundle inlined on the rendered html page that pattern lab shows you. That page is not really a consumable asset, so maybe it doesn't matter much, as long as it works.

The way we produce consumable assets (if at all, maybe consuming projects can just refer to the pattern files in patterns/ as-is) is a different matter.

bramsmulders commented 7 years ago

Hey @geoffp, This pull request is adressing this issue: https://github.com/pattern-lab/patternengine-node-react/pull/2 It works with atoms-button syntax. check it out!