search

pattern-lab / patternengine-php-twig

Twig-based PatternEngine for Pattern Lab.
http://patternlab.io/
MIT License
78 stars 36 forks source link

Update Twig to version 2 #41

Open renestalder opened 7 years ago

renestalder commented 7 years ago

Patternengine PHP Twig still uses Twig < 2. In my case, I create reusable component libraries with Patternlab. Those can be used in CMS out of the box. The problem is, that most of those CMS use Twig 2, thus there are some incompatibilities which don't occur for me in Patternlab, but come up when used in a Twig 2 environment.

sghoweri commented 7 years ago

@renestalder any chance you could add his issue over on the Drupal Pattern Lab fork @EvanLovely and I have been actively maintaining? https://github.com/drupal-pattern-lab/patternengine-php-twig

Considering how Drupal 8.4 is slated to use Twig v2, I definitely think this should get taken care of sooner rather than later!

mkoe-unitb commented 6 years ago

It is still Twig < 2. Do you found a workaround?

renestalder commented 6 years ago

@mkoe-unitb I still use Twig v1 that get's included in Twig v2. In most cases it's not a problem. Twig 2 mostly is just more strict. I didn't find breaking changes that came into my way.