search

pattern-lab / patternlab-node-cli

Moved to https://github.com/pattern-lab/patternlab-node/tree/dev/packages/cli
MIT License
21 stars 5 forks source link

Starterkit installation fails for any starterkit without a package.json #15

Closed bmuenzenmeyer closed 7 years ago

bmuenzenmeyer commented 7 years ago

https://github.com/pattern-lab/patternlab-node-cli/blob/master/bin/init.js#L101-L160

raphaelokon commented 7 years ago

@bmuenzenmeyer Can you explain on this one?

bmuenzenmeyer commented 7 years ago

so we've had problems with npm/requiring starterkits in the past because their package.json files were missing a main entrypoint. this was a placeholder issue to make mention of all "official" starterkits that are still to be changed, like: https://github.com/pattern-lab/starterkit-mustache-bootstrap

i will turn this into a to-do list

raphaelokon commented 7 years ago

Oh I missed that, thanks! I will also try to think about a way to check for existence without a main in package.json

raphaelokon commented 7 years ago

@bmuenzenmeyer I noticed that https://github.com/pattern-lab/starterkit-mustache-base cannot be installed via npm because no package.json …

bmuenzenmeyer commented 7 years ago

@raphaelokon all starterkits are done. feel free to retest that suite you showed me earlier and close this if it looks good

raphaelokon commented 7 years ago

@bmuenzenmeyer Cheers for updating the starter kits

raphaelokon commented 7 years ago

https://github.com/pattern-lab/starterkit-mustache-materialdesign/blob/master/package.json This one is still missing a main I guess

bmuenzenmeyer commented 7 years ago

ugh. repushed. check again! off to bed for me

raphaelokon commented 7 years ago

Enjoy! Works now – tests do pass. This will be fixed with the next bigger release.