search

pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 405 forks source link

Support Pattern Search #101

Closed getsetbro closed 9 years ago

getsetbro commented 9 years ago

http://getsetbro.com/pl-nodeV8/public/

Page Follow and Auto Reload do not seem to do anything in the settings menu.

bmuenzenmeyer commented 9 years ago

To be honest, I don't recall specifically investigating support for search during the port, which has been in dev for over a year and morphed as PL PHP has a bit.

I will investigate this as part of v1.0.0 (a contribution is welcome too :smile: ). I will be renaming this issue to "Support Pattern Search."

Page follow was investigated in https://github.com/pattern-lab/patternlab-node/pull/86 but navigation did not work as expected. This is something I'd like to get working at some point. I've opened an issue for this https://github.com/pattern-lab/patternlab-node/issues/103.

Live reload works oob with the grunt tasks when launched as grunt serve. This option should just be removed from PL Node as it doesn't really make sense. I've opened an issue for this: https://github.com/pattern-lab/patternlab-node/issues/102

bmuenzenmeyer commented 9 years ago

This is currently turned off by default in the navigation, but we should just get it working :)

bmuenzenmeyer commented 9 years ago

Hey @getsetbro this was just pushed to dev branch. If you could upgrade and verify functionality I would appreciate it. Otherwise I'll hammer on it a bit more too :)

getsetbro commented 9 years ago

Boom. Roasted.

christophrumpel commented 9 years ago

Is the search functionality already in the current release? Can't find any information about it?

bmuenzenmeyer commented 9 years ago

Hi @christophrumpel

you should see it on the current release on the top right of the style guide

image

It's behind the find flag in config.json https://github.com/pattern-lab/patternlab-node/blob/master/config.json

christophrumpel commented 9 years ago

Ah I see. Thanks. I thought there might be some info in the documentation on how it works or something similar. But I will try it now myself. Thx!