search

pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 408 forks source link

Fully support .html.twig suffix #1030

Open aleksip opened 5 years ago

aleksip commented 5 years ago

I am using Pattern Lab Node v3.0.1 on macOS, with Node v10.6.0, using the Twig Edition.

Expected Behavior

Use .html.twig suffix for patterns without any problems.

This style of suffix is advocated in Symfony documentation and is also used by Drupal. In some cases, e.g. when registering layout templates, Drupal expects the layout template to have a .html.twig suffix.

Actual Behavior

Twig template source/rendered HTML not shown in UI, possible other problems.

Steps to Reproduce

Use .html.twig suffix for patterns.

stale[bot] commented 5 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

aleksip commented 5 years ago

Hi there, stale bot!

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

aleksip commented 4 years ago

Good old stale bot!

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

backlineint commented 4 years ago

I've also been tracking this issue. It is specifically problematic for layouts in Drupal 8 as @aleksip mentioned. I've done some work on a module that automatically derives layouts from a Pattern Lab instance (https://www.drupal.org/project/layouts_pattern_lab), but bug means that some workarounds are required in order to use this with the node version of Pattern Lab.

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

backlineint commented 4 years ago

Keeping this one alive...

pcate-fls commented 4 years ago

Has anyone found a workaround for this issue?

mfranzke commented 2 years ago

@aleksip are you using the extension ‚.html.twig‘ as a „mix and match“ with other files having the ‚.twig‘ as well in the same codebase, or are all of the files strictly named only in one of of those variations?