pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 408 forks source link

Implement "density" option from patternlab-config.json #1051

Open thethomic opened 5 years ago

thethomic commented 5 years ago

I am using Pattern Lab Node v3.0.3 on Windows, with Node v8.11.2, using a `Gulp Edition.

Expected Behavior

The patternLab navigation should render differently depending on the option theme.density in the patternlab-config.json. Defined values are: "density" : "compact" | "cozy" | "comfortable",

Actual Behavior

The theme.density option doesn't have any effect

Steps to Reproduce

Build a patternLab, open in browser, look at patternLab navigation

info from @sghoweri :

This is one of the handful of Pattern Lab UI features that hasn’t gotten rebuilt / moved over (yet) — mostly just due to time and detangling some spaghetti code. The main obstacle to re-enabling this is mostly just the lack of designs to go off of on what these different density settings should look like / translate to.

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

sghoweri commented 4 years ago

Bump - this should actually be doable in the near future, particularly once full CSS Variable support is added to UIKit which will density support a heck of a lot easy to roll out!

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] commented 4 years ago

Issue closed after going stale. It can be re-opened if still relevant.

JosefBredereck commented 4 years ago

Stale Reopen