Items that are currently not working

[getsetbro]

Comment thread is empty http://getsetbro.com/pl-nodeV8/public/?p=organisms-comment-thread

Carousel http://getsetbro.com/pl-nodeV8/public/?p=organisms-carousel

Accordion http://getsetbro.com/pl-nodeV8/public/?p=molecules-accordion But I see it doesn't do anything on the PHP demo http://demo.patternlab.io/?p=molecules-accordion

[bmuenzenmeyer]

Hi Seth - thanks for the ping on twitter. I saw this the other day. I plan to look at another round of fixes soon.

[bmuenzenmeyer]

Curious @dmolsen if you think we should even ship with working UI components like a carousel. Pattern Lab is not a UI framework, and I worry about people attempting to use a OOB accordion or carousel. Like most things, we should strike a balance between example uses and vanilla tool/platform.

cc @bradfrost

[dmolsen]

@bmuenzenmeyer -

My answer is "no." The demo was a bit of mistake. As @bradfrost notes in styles.css "...please don't use these styles. They're just here to put together the demo, and nothing more." PL2 has an empty base StarterKit (Twig example). The demo will still be available as a StarterKit but hopefully the directions guide them towards building their own thing first from the "empty" one. If maintaining the back-end of PL is time consuming I couldn't imagine maintaining real, tested UI patterns.

[getsetbro]

I'm considering making a bootstrap based starter kit. Thoughts?

[dmolsen]

@getsetbro -

I think it would be awesome. I have a defined file structure format for StarterKits installs in PL2 for PHP. If that could be used that would be great. It should work just fine for Node too since the worse thing that happens is someone downloads the StarterKit and copies and pastes a directory.

Example structure Example composer.json for simplifying installs w/ PL2 for PHP

It can live under your account. Frankly, that'd be best.

[getsetbro]

I was expecting it to be the source folder but I see you have the dist?

If I use just html and nothing mustache or twig specific than it will be agnostic. But what would the file extension be? "file.html"?

I started the repo, we can discuss here: https://github.com/getsetbro/patternlab-bootstrap-starterkit/issues/1

[bmuenzenmeyer]

In the case of pl node, you could save pure HTML as .mustache and it would get picked up fine IIRC.

On Sunday, March 8, 2015, Seth Broweleit notifications@github.com wrote:

I was expecting it to be the source folder but I see you have the dist?

If I use just html and nothing mustache or twig specific than it will be agnostic. But what would the file extension be? "file.html"?

— Reply to this email directly or view it on GitHub https://github.com/pattern-lab/patternlab-node/issues/106#issuecomment-77767265 .

[getsetbro]

FYI, this might be another bug. A css file added to source/css/ does not get copied to public/css but a JS file added to source/js/ does get copied to public/js.

[bmuenzenmeyer]

Not a "bug," just a oversight in Gruntfile.js:

 { expand: true, cwd: './source/js/', src: '*', dest: './public/js/'},
 { expand: true, cwd: './source/css/', src: 'style.css', dest: './public/css/' },

Change the css src to '*.css'

I have changed this in my working copy of dev. Thanks

[bmuenzenmeyer]

@getsetbro to answer your comment more directly about the bootstrap version - I echo how cool this would be but agree with Dave in that it should be a starter-kit repo not part of pl-node core. PatternLab is not a ui framework. Shipping with Bootstrap is far too opinionated.

That said, if you build this, I would be more than happy to add it to our readme or start a wiki. I've been kicking around the idea of a wiki for a while since patternlab.io/docs are in flux.

[bmuenzenmeyer]

Per this conversation and https://github.com/pattern-lab/patternlab-node/issues/109 I am closing this issue