search

pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 408 forks source link

Resolve broken links in new docs site #1153

Closed bmuenzenmeyer closed 4 years ago

bmuenzenmeyer commented 4 years ago

I used https://validator.w3.org/checklink to checkout our new doc site, previewed at: https://patternlab-docs-preview.netlify.app/

This is prerequisite for cutting over the docs site.

There are a number of broken links we need to resolve. My best attempt at scraping the w3c results and deduping looks like this:

https://patternlab-docs-preview.netlify.app/resources https://patternlab.io//docs/template-language-and-patternengines/ https://patternlab-docs-preview.netlify.app/resources/ https://patternlab.io//docs/starterkits/ https://patternlab-docs-preview.netlify.app/docs/pattern-reorganizing.html https://patternlab-docs-preview.netlify.app/docs https://patternlab.io//feed.xml https://patternlab.io//docs/using-pattern-states/ https://patternlab.io//updates/ https://patternlab.io//docs/managing-pattern-assets/ https://patternlab.io//docs/creating-pattern-specific-values/ https://patternlab.io//docs/modifying-the-pattern-header-and-footer/ https://patternlab-docs-preview.netlify.app/docs/advanced-auto-regenerate.html https://patternlab-docs-preview.netlify.app/docs/pattern-including.html https://patternlab.io//docs/keyboard-shortcuts/ https://patternlab.io//docs/using-pseudo-patterns/

cc @frostyweather @bradfrost

frostyweather commented 4 years ago

@bmuenzenmeyer A comment and question:

Do these need to have the same URL structure as the live site or is it okay for these to be different? I think most of the URLs posted above from the new site are just because the title has been renamed.

bmuenzenmeyer commented 4 years ago

Good questions. The crawler found those links somewhere on the new site and they broke. Navigate around and you will find some.

The goal is to ferret these out wherever they are

frostyweather commented 4 years ago

@bmuenzenmeyer Alrighty. I found the issue with resources. I'll take a look at the others and fix them if they need to be fixed.

frostyweather commented 4 years ago

@bmuenzenmeyer @bradfrost For the documentation page, do we still want that since all of our docs are in the nav now?

frostyweather commented 4 years ago

@bmuenzenmeyer @bradfrost In terms of the new site:

Assuming those are the ones we should focus on since we are launching the new site soon.

frostyweather commented 4 years ago

@bmuenzenmeyer Just created a pull request for this. All of the new links should be resolved. The old links from above have either been renamed or no longer have any significance.