search

pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 405 forks source link

Meta head & foot are not rendered an equal amount of times #1212

Open ringods opened 4 years ago

ringods commented 4 years ago

I am using Pattern Lab Node v5.9.3 on Mac, with Node v12.16.3, using a Custom Edition with engine-twig

Expected Behavior

Meta head & foot to be rendered the same amount of times.

Actual Behavior

Meta foot is rendered more times.

Steps to Reproduce

In trying to track the cause of #1201, I bumped into a strange behavior of PL. I added a log statement in the renderPattern call of engine-twig. In the example project, only rendering a single pattern, there are two additional summary pages. In this case, I expect the _meta/_00-head.twig and _meta/_01-foot.twig to be rendered 3 times. However, I get this:

$ patternlab build --config ./patternlab-config.json
Pattern Lab Node v5.9.3
Pattern Engine handlebars: good to go
Pattern Engine mustache: good to go
Pattern Engine twig: good to go
renderPattern(_00-head.twig)
renderPattern(_00-head.twig)
renderPattern(00-atoms/01-text/00-headings.twig)
renderPattern(_01-foot.twig)
renderPattern(_01-foot.twig)
Built pattern: atoms-headings
Built pattern: atoms-headings
renderPattern(_00-head.twig)
renderPattern(_01-foot.twig)
renderPattern(_01-foot.twig)
renderPattern(_01-foot.twig)
Built Pattern Lab front end
⊙ patternlab → build: Yay, your Pattern Lab project was successfully built ☺

The head is rendered 3 times, but the footer is rendered 5 times. How does this come?

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] commented 4 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] commented 3 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!

stale[bot] commented 2 years ago

It's hard to keep track of everything. This issue has been automatically marked as stale because it has not had recent activity, neither from the team nor the community. It will be closed if no further activity occurs. Please consider adding additional info, volunteering to contribute a fix for this issue, or making a further case that this is important to you, the team, and the project as a whole. Thanks!