search

pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 405 forks source link

Viewing annotations strips down margin in pattern #215

Closed nielsvanmidden closed 7 years ago

nielsvanmidden commented 8 years ago

Background

Annotations are stripping down pattern margins.

Steps to reproduce

As you can see in the images attached, the margins are now stripped down.

3 2 1

bmuenzenmeyer commented 8 years ago

Hi @nielsvanmidden - thanks for reporting and for using Pattern Lab. I quick tried this with some existing annotations I have in a 0.14.0 build of PL Node and did not witness this behavior.

I will set up a heading block like this and try again. Any additional mustache, css, or annotation logic you can provide would be helpful.

A small final note I'll be moving toward a more unified experience with PL PHP starterkits someday, so substantial improvements to the PL Node frontend will likely not occur via me.

nielsvanmidden commented 8 years ago

Ah, so this means it is better to report general front end issues here?

I'm using PL-node-v1.0.0.

bmuenzenmeyer commented 8 years ago

Frontend issues can certainly be reported here. The point I was trying to make, ineloquently at that, is that it's tougher for me to pinpoint exactly where they may get prioritized, since some are duplicates of things found in PL PHP, some are unique, some are interesting/quirky (like yours), and some are going to be blown away by proposed/future changes to the frontend.

tl;dr: Open a ticket and I can play clean up.

Thanks!

nielsvanmidden commented 8 years ago

Ah, thanks for the explanation.

nielsvanmidden commented 8 years ago

Will the assets in the style-guide-assets repository eventually be a dependency of PL Node and PL PHP? And does it make sense to report certain issues in that repository then?

In the attachment you can find my patterns, annotations and style. pattern-demo.zip

bmuenzenmeyer commented 8 years ago

Hi @nielsvanmidden that is my eventual goal, yes. I can't speak to how long it will be until I get there. That repo is a dependency for PL PHP v2 as I recall.

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.