search

pattern-lab / patternlab-node

The Node version of Pattern Lab
http://patternlab.io
MIT License
2.05k stars 405 forks source link

StarterKits should be able to override settings in patternlab-config.json #628

Closed tburny closed 7 years ago

tburny commented 7 years ago

I am using Pattern Lab Node v2.7.2 on Linux, with Node v4.6.2, using the Gulp or Grunt Edition.

By discussion with @bmuenzenmeyer: I created a Demo StarterKit which is using the Thymol engine. However the Gulp/Grunt Edition come with mustache as preconfigured patternExtension.

StarterKits should be able to overwrite fields in the Edition's [patternlab-config.json](url) so I can change it to "patternExtension": "html" automatically upon npm install.

When a StarterKit is loaded by Pattern Lab, it should look for a starterkit-config.json file, which contains all properties that have to be overridden in the edition's.

We agreed that instead of copying a whole configuration file it would be better to read the starterkit-config.json into patternlab.config and serialize the config file back to disk again - similar to how it is already done for plugins.

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.