search

pattern-lab / patternlab-php-core

This repository provides the core functionality for Pattern Lab. It is meant to be used from within an Edition with a PatternEngine and StarterKit.
http://patternlab.io/
MIT License
43 stars 62 forks source link

Proposal: Adopt Symfony coding stardards #150

Open aleksip opened 7 years ago

aleksip commented 7 years ago

Pattern Lab PHP uses many Symfony components, so it might make sense to adopt their coding standards. They also have a nice tool, the PHP Coding Standards Fixer, which we could run on our entire PHP codebase.

sghoweri commented 7 years ago

^ and could probably use even more Symphony components to further reduce the amount of custom code needing to be maintained.

@aleksip at a high level, what sort of things would adopting Symphony's coding standards change? Please oh please oh please don't say we need to switch back over to using tabs 😜

EvanLovely commented 7 years ago

Love this

aleksip commented 7 years ago

and could probably use even more Symphony components to further reduce the amount of custom code needing to be maintained

Indeed! Actually, I have some secret plans related to this I'm hoping to advance next week. 😉

Please oh please oh please don't say we need to switch back over to using tabs

Symfony follows PSR-2 which dictates that code MUST use 4 spaces for indenting, not tabs!

EvanLovely commented 7 years ago

secret plans

😳🤔

aleksip commented 7 years ago

Not evil ones, I promise! 😈 😄

Just planning to find out if some custom PL code could be replaced with a drop in Symfony replacement with no side effects!