search

pattern-lab / patternlab-php-core

This repository provides the core functionality for Pattern Lab. It is meant to be used from within an Edition with a PatternEngine and StarterKit.
http://patternlab.io/
MIT License
43 stars 62 forks source link

Move Twig-specific code from core to patternengine-php-twig #158

Open aleksip opened 6 years ago

aleksip commented 6 years ago

LineageHelper has some special handling for Twig. We should move this to patternengine-php-twig as core should be templating engine agnostic.

I think this should be possible to do by adding a PatternLabListener.php to patternengine-php-twig and hooking into patternData.lineageHelperStart or patternData.lineageHelperEnd.

@sghoweri Would you like to have a go at this? :)

sghoweri commented 6 years ago

Sounds like something right up my alley 🙂

If you could reassign this to me I can take care of this this week!