search

pattern-lab / patternlab-php-core

This repository provides the core functionality for Pattern Lab. It is meant to be used from within an Edition with a PatternEngine and StarterKit.
http://patternlab.io/
MIT License
43 stars 62 forks source link

Bug in configuring patternengines (and listeners?) since PHP 8.0 #177

Open percoction opened 2 years ago

percoction commented 2 years ago

We use patternlab-php-core and edition-php-twig-standard in our project.

We noticed that since PHP 8.0 the config in config/patternengines.json is missing the class namespaces.

I believe this due to an update to the functionality of the token_get_all() built in PHP function, used in InstallerUtil::findClasses().

The fix may be as simple as updating line 135 to consider the new namespace token types: if (in_array($tokens[$i][0], array(T_STRING, T_NS_SEPARATOR, T_NAME_FULLY_QUALIFIED, T_NAME_QUALIFIED, T_NAME_RELATIVE))) {

joshuathorne commented 2 years ago

I'm also experiencing this build error. patternlab updated config/patternengines.json to: {"patternengines":["\\PatternLab\\PatternEngine\\Twig\\PatternEngineRule","\\PatternEngineRule"]}

error is: PHP Fatal error: Uncaught Error: Class '\PatternEngineRule' not found in /app/vendor/pattern-lab/core/src/PatternLab/PatternEngine.php:71

I resolved it by manually changing patternengines.json to: {"patternengines":["\\PatternLab\\PatternEngine\\Twig\\PatternEngineRule"]}