search

pattern-lab / patternlab-php-core

This repository provides the core functionality for Pattern Lab. It is meant to be used from within an Edition with a PatternEngine and StarterKit.
http://patternlab.io/
MIT License
43 stars 62 forks source link

Fix failure to reset variables in loop #86

Closed rocketeerbkw closed 8 years ago

rocketeerbkw commented 8 years ago

When generating patternLabHead and patternLabFoot for patternType partials, the variables that hold the rendered strings were named incorrectly, which caused the header and footer to contain the rendered strings of the last rendered patternSubType (due to data hanging around from the last loop), or nothing if it was the first patternType.

This cause two bugs for us. 1) The styleguide.min.css was missing on our Atoms > View All, and 2) Clicking on Molecules > View All would actually load Atoms > Images instead.

dmolsen commented 8 years ago

This was fixed in dev a week or so ago. I've been away and hadn't had a chance to cut a new release. Thanks for the PR and I'll get the fix out for real sometime this week.