search

pattern-lab / starterkit-mustache-bootstrap

A Bootstrap starter kit for Pattern Lab
MIT License
23 stars 23 forks source link

Fonts are missing from dist #11

Open bmuenzenmeyer opened 8 years ago

bmuenzenmeyer commented 8 years ago

the css is expecting dist/fonts/ to have glyphicons files to load https://github.com/pattern-lab/starterkit-mustache-bootstrap/blob/master/dist/css/bootstrap.css#L263-L268

bradfrost commented 8 years ago

@bmuenzenmeyer cool thanks for the heads up. Assigning to @frostyweather to investigate.

frostyweather commented 8 years ago

@bmuenzenmeyer Hey Brian. The glyphicons look to be showing up correctly on my local version of the bootstrap pattern lab. Are things not compiling due to CSS expecting dist/fonts/ to have glyphicons files to load?

frostyweather commented 8 years ago

@bmuenzenmeyer screen shot 2016-06-15 at 2 58 11 pm

bmuenzenmeyer commented 8 years ago

@frostyweather I'll recheck - it's 100% possible I did something silly on my end

frostyweather commented 8 years ago

Alrighty. Keep me posted and I'll work with you on that. Thanks!

bmuenzenmeyer commented 8 years ago

Reconfirmed. The CSS is attempting to load ../fonts/glyphicons-halflings-regular.eot at this line https://github.com/pattern-lab/starterkit-mustache-bootstrap/blob/69fecfe16d165fd1a246c47d71b61808105d1704/dist/css/bootstrap.css#L266

Which does not exist https://github.com/pattern-lab/starterkit-mustache-bootstrap/tree/69fecfe16d165fd1a246c47d71b61808105d1704/dist/fonts

image

I wonder if PL/PHP does something I am not expecting, regarding these starterkits. It's my understanding that dist/ should be directly consumable as source/

bmuenzenmeyer commented 8 years ago

@frostyweather

It's also worth noting that your pattern tree has TEMPLATES and PAGES in the navigation, but it's not coming from https://github.com/pattern-lab/starterkit-mustache-bootstrap/tree/master/dist/_patterns

????

dmolsen commented 8 years ago

Not an issue with PL/PHP. The fonts and templates/pages aren't in the StarterKit repo. I pulled a dev version and added the Bootstrap StarterKit and I'm seeing the same problems as @bmuenzenmeyer .

frostyweather commented 8 years ago

Hmmmm. I knew I never liked those glyphicons when I was shoveling the bootstrap stuff over to PL. Are there actual fonts in the font folder for the starterkit like this? screen shot 2016-06-15 at 5 06 29 pm

dmolsen commented 8 years ago

They're not in the repo. This is what we can pull.

https://github.com/pattern-lab/starterkit-mustache-bootstrap/tree/master/dist/fonts

On Jun 15, 2016, at 5:07 PM, frostyweather notifications@github.com wrote:

Hmmmm. I knew I never liked those glyphicons when I was shoveling the bootstrap stuff over to PL. Are there actual fonts in the font folder for the starterkit like this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

frostyweather commented 8 years ago

My repo is just from a separate bootstrap site I made. Want me to send the fonts to you to see if it works for you?

On Wednesday, June 15, 2016, Dave Olsen notifications@github.com wrote:

They're not in the repo. This is what we can pull.

https://github.com/pattern-lab/starterkit-mustache-bootstrap/tree/master/dist/fonts

On Jun 15, 2016, at 5:07 PM, frostyweather <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Hmmmm. I knew I never liked those glyphicons when I was shoveling the bootstrap stuff over to PL. Are there actual fonts in the font folder for the starterkit like this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pattern-lab/starterkit-mustache-bootstrap/issues/11#issuecomment-226322840, or mute the thread https://github.com/notifications/unsubscribe/ANB6e2srTrKSx-1i7P9DiL00N8T2B7-Eks5qMGvKgaJpZM4IpHQi .

frostyweather commented 8 years ago

Here is the compressed folder of the glyphicon fonts. Try it out and let me know if there is still an issue. Thanks.

glyphicon-fonts.zip

dmolsen commented 8 years ago

So copying those into my local copy of the StarterKit running in a development edition works. Up to a point. It's not styled at all in the way that you have shown above. I'm assuming this is because we're missing styles that you put into ./source/styleguide/css/styleguide-specific.min.css or whatever the hell it is since I'm writing that from memory.

So I think we need to determine the following:

  1. Is the glyphicon font supposed to be included in the StarterKit? If so I have the files and can update the repo.
  2. Do we need to style it the way it is presented upthread? If so do you have the changes for that that we can get merged in somehow.
  3. Is this StarterKit supposed to have templates or pages? It's fine if it won't we're just going to have to work up a README that explains what all comes with this. It would be good to have a stand-in template and pages folder just so people get that they can build those out.
  4. We need to find a better way to handle styleguide-specific.min.css and I'll propose a spec change we can implement fairly quickly.
  5. How close are the Bootstrap, Foundation, and Material Design StarterKits to being finished that we can highlight them? Foundation doesn't have templates or pages. Material Design (from quickly looking at source, not testing) looked like it didn't have styles.

I'm guilty of delaying PL/PHP again and again so the last one I completely understand. I think as we move towards that workshop we just need to know where this stuff stands. It's not enough to have code. Stuff needs to be documented so we're all on the same page about what can or can't be done with these.

dmolsen commented 8 years ago

Related to point 4 above: pattern-lab/the-spec#20

frostyweather commented 8 years ago
  1. I'm not sure of the importance of the glyphicon stuff. I'd ask @bradfrost about that.
  2. The way it is styled is just how bootstrap styles the glyphicons.
  3. The starterkit I created does not have any templates or pages. All I added were the various components included in bootstrap. I did the same for Foundation and Material Design
  4. The bootstrap specific CSS should be included within the starter kit repo. The same goes for Foundation and Material Design
  5. The components and styles should be correct in Bootstrap and Foundation. Material Design is a little wonky with some of the header components.

Basically what I did was create 3 separate pattern lab sites where I added downloaded components from Bootstrap, Foundation, and Material Design so I could actually see what I was created. Then I moved these files into the starterkit repos. Here's how they look on my computer. I didn't actually build out any pages with them.

Material Design screen shot 2016-06-15 at 10 28 47 pm Bootstrap screen shot 2016-06-15 at 10 29 09 pm Foundation screen shot 2016-06-15 at 10 29 57 pm

frostyweather commented 8 years ago

Here are the bootstrap and foundation sites I made. pl-bootstrap.zip pl-foundation.zip

dmolsen commented 8 years ago

@frostyweather -

Thanks. With the Zips in hand I can see where we're missing styles. The repos definitely don't match with what you've shared. I'll run through this weekend using those files to get those items updated in the repos. If I run into issues I'll pop them onto the appropriate repo.

frostyweather commented 8 years ago

Hope it helps, Dave. I know you guys are busy wrapping things up so if I can help in any way let me know. I just haven't been in the loop for a while which is why I wasn't sure how much help I could be. Also, I wasn't able to send the material design one because even when zipped it was too large. If you need it I could figure out a way to get it to you. Thanks again and my apologies for the complications.