search

pattern-lab / starterkit-mustache-bootstrap

A Bootstrap starter kit for Pattern Lab
MIT License
23 stars 23 forks source link

Update for Bootstrap v4 #15

Open bmuenzenmeyer opened 6 years ago

bmuenzenmeyer commented 6 years ago

https://getbootstrap.com/

bmuenzenmeyer commented 6 years ago

Some users expressed interest in this update - but it needs an active maintainer 😄

bradfrost commented 6 years ago

Yeah this would be interesting. I don't know what a port of Bootstrap 3 would entail, but I'm not willing to do the work myself. That said, I'd be happy to coach anyone who would want to take that project on.

bmuenzenmeyer commented 6 years ago

someone did in chat - prompting me to open this issue in the first place. have not heard from him or her since

miklb commented 6 years ago

I'm working with a few folks interested in using v4 of Bootstrap with Pattern Lab. We would be interested in contributing the work back if you have any pointers on where to start. I'm getting up to speed on the basics of the php versions now.

bradfrost commented 6 years ago

Hey thanks @miklb! Probably the easiest way to get started would be to create a new branch in this repo and update the styles and components to match Bootstrap v4. Lemme know if you hit any snags and I can hopefully get you unstuck.

bmuenzenmeyer commented 6 years ago

The templates in thus repo can be whatever helps users get started with bootstrap without being too opinionated. Regardless of the current demo. So think atoms like buttons, badges.... molecules like cards. Anything bootstrap. Sky is the limit!

On Mon, Jun 4, 2018, 11:04 PM Michael Bishop notifications@github.com wrote:

@bradfrost https://github.com/bradfrost I'm looking over https://github.com/pattern-lab/starterkit-mustache-demo and it seems there's been quite a bit of change to the mustache templates. How close should the mustache templates match or is that dependent on the bootstrap markup? Apologies if that's a dumb question, I'm still fully familiarizing myself with patternlab.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pattern-lab/starterkit-mustache-bootstrap/issues/15#issuecomment-394574671, or mute the thread https://github.com/notifications/unsubscribe-auth/AASNw0nYNF5mys7bKohDQdtdLdGGD3cJks5t5gNQgaJpZM4SgsfE .

rachelreveley commented 4 years ago

Did anything come of this? The place I work at is planning to incorporate pattern Lab into the workflow and we use BS 4.

miklb commented 4 years ago

Not on my end. Went another direction.

bmuenzenmeyer commented 4 years ago

Did anything come of this? The place I work at is planning to incorporate pattern Lab into the workflow and we use BS 4.

sounds like a great first step would be giving this starterkit some attention, as it could be the basis of your future work. Mustache is not really the best of breed templating solution, however, so you may want to look into other templating engines, as constraints allow

kentr commented 4 years ago

I'm making a go at this, but with twig.