pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

setting up "bower install" in "postinstall" hook #10

Closed EvanLovely closed 7 years ago

EvanLovely commented 8 years ago

With these changes, bower install is ran automatically after npm install so it's not forgotten and bower does not need to be globally installed before (no need to npm install --global bower) as all scripts from package.json have all dependencies added to their $PATH (which just reside in ./node_modules/.bin/).

bmuenzenmeyer commented 7 years ago

This looks smart - will be trying it today.

bmuenzenmeyer commented 7 years ago

@EvanLovely testing this does not appear to work on my machine

Windows 10 Node 5.5.0 bower 1.8.0 installed via npm

ran npm run postinstall

did not re-add jquery, defined in the bower.json file

Am I testing correctly?

bmuenzenmeyer commented 7 years ago

going away long term