Closed mremergo closed 8 years ago
@mremergo can you also provide a screenshot of the filestructure inside source/_patterns/
please?
Just the folders folders and files
@mremergo -
I think it might be an issue with patternPaths
. Mind copying in var patternPaths
too, please? I'm going to try to recreate this deep level of patterns in PL/PHP to see if I can get to this bug. I know my testing didn't go that far. I realize you're using Node but it might be a common problem across both platforms.
An important note - meta
should be outside of _patterns
as of 2.0.0. See these upgrade instructions for my running list of things to do during migration.
Or have you just named your own directory meta as well as having the similarly named directory as a sibling of _patterns/
?
00-atoms > 02-aside > menu-component-parts > menu-buttons is more menu levels than PL/Node's navigation building supports. Is an arbitrary amount of these on spec @dmolsen ?
Thx for the awesome help/response, really appreciate it!
@bmuenzenmeyer thx for pointing out. I have _meta in /source. the 00_meta was only a leftover containing some dummy atoms (not containing the pattern head or foot files anymore). I renamed 00_meta, but without any influence on topic. @dmolsen the patternPaths var
{
"atoms": {
"header-button-help": "00-atoms/01-header/header-component-parts/header-button-help",
"header-button-logout": "00-atoms/01-header/header-component-parts/header-button-logout",
"header-button-menu-toggle": "00-atoms/01-header/header-component-parts/header-button-menu-toggle",
"header-languagepicker": "00-atoms/01-header/header-component-parts/header-languagepicker",
"header-logo": "00-atoms/01-header/header-component-parts/header-logo",
"menu-button-active-state": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-active-state",
"menu-button-bars": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-bars",
"menu-button-bookmarks": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-bookmarks",
"menu-button-container": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-container",
"menu-button-desktop": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-desktop",
"menu-button-empty": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-empty",
"menu-button-forms": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-forms",
"menu-button-help": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-help",
"menu-button-modal-dialog": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-modal-dialog",
"menu-button-notifications": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-notifications",
"menu-button-profile": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-profile",
"menu-button-settings": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-settings",
"menu-button-stop": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-stop",
"menu-button-tables": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-tables",
"main-context-help-button": "00-atoms/03-main/context-help/main-context-help-button",
"form-checkbox": "00-atoms/03-main/form-component-parts/form-checkbox",
"form-datepicker": "00-atoms/03-main/form-component-parts/form-datepicker",
"form-dropdown-advanced": "00-atoms/03-main/form-component-parts/form-dropdown-advanced",
"form-dropdown-simple": "00-atoms/03-main/form-component-parts/form-dropdown-simple",
"form-filepicker": "00-atoms/03-main/form-component-parts/form-filepicker",
"form-input-password": "00-atoms/03-main/form-component-parts/form-input-password",
"form-input-text": "00-atoms/03-main/form-component-parts/form-input-text",
"form-input-text-required": "00-atoms/03-main/form-component-parts/form-input-text-required",
"form-mandatory": "00-atoms/03-main/form-component-parts/form-mandatory",
"form-radiobuttons": "00-atoms/03-main/form-component-parts/form-radiobuttons",
"form-select-multiple": "00-atoms/03-main/form-component-parts/form-select-multiple",
"form-textarea": "00-atoms/03-main/form-component-parts/form-textarea",
"pagination": "00-atoms/03-main/pagination/pagination",
"table-standard": "00-atoms/03-main/tables/table-standard",
"table-striped": "00-atoms/03-main/tables/table-striped",
"table-with-sort": "00-atoms/03-main/tables/table-with-sort",
"text-button-default": "00-atoms/05-misc/buttons/text-button-default",
"text-button-primary": "00-atoms/05-misc/buttons/text-button-primary",
"notification-danger": "00-atoms/05-misc/notifications/notification-danger",
"notification-success": "00-atoms/05-misc/notifications/notification-success",
"notification-warning": "00-atoms/05-misc/notifications/notification-warning"
},
"molecules": {
"menu-dropdown-button": "01-molecules/02-aside/menu-components/menu-dropdown-button",
"form-fieldset": "01-molecules/03-main/form/form-fieldset",
"form-group-error": "01-molecules/03-main/form/form-group-error",
"accordion": "01-molecules/03-main/main-components/accordion",
"jarvis-widget": "01-molecules/03-main/main-components/jarvis-widget",
"jarvis-widget-no-footer": "01-molecules/03-main/main-components/jarvis-widget-no-footer",
"ribbon": "01-molecules/03-main/main-components/ribbon",
"tabs": "01-molecules/03-main/main-components/tabs",
"table-responsive": "01-molecules/03-main/pager-tables/table-responsive",
"table-responsive-alternative": "01-molecules/03-main/pager-tables/table-responsive-alternative"
},
"organisms": {
"header": "02-organisms/01-header/header",
"aside": "02-organisms/02-aside/aside",
"form-example-complete-showcase": "02-organisms/03-main/form-examples/form-example-complete-showcase",
"form-example-empty": "02-organisms/03-main/form-examples/form-example-empty",
"form-example-small-form": "02-organisms/03-main/form-examples/form-example-small-form",
"form-example-ticket-details": "02-organisms/03-main/form-examples/form-example-ticket-details",
"form-example-ticket-search": "02-organisms/03-main/form-examples/form-example-ticket-search",
"form-example-ticket-search-versaform": "02-organisms/03-main/form-examples/form-example-ticket-search-versaform",
"footer": "02-organisms/04-footer/footer",
"modal-dialog": "02-organisms/05-misc/modal-dialogs/modal-dialog",
"login-screen": "02-organisms/05-misc/modal-screens/login-screen",
"progress-indicator": "02-organisms/05-misc/modal-screens/progress-indicator"
},
"templates": {
"template": "03-templates/template",
"template-site-mods": "03-templates/template-site-mods"
}
}
Bad news. Good news.
I recreated your organization for header-button-help
and header-button-logout
and both the generation of the patterns with the PHP version of PL and the front-end worked just fine. I even duped the navItems
and patternPaths
you provided above and clicking the nav between those elements that exist worked.
From my standpoint I think I need to get to installing PL/Node and see if I can recreate. I need a local version anyway.
Double-check that ./public/patterns/00-atoms/01-header/header-component-parts/header-button-help.html
exists. And make sure ./styleguide/js/patternlab-pattern.min.js
is loading inside the iFrame. That's what's listening for the postMessage call to change/update the iFrame source. ?p=pattern
sets the iFrame source from the "outside" on page load.
@dmolsen I'd expect that level of nesting to work, but what of something like:
menu-button-modal-dialog": "00-atoms/02-aside/menu-component-parts/menu-buttons/menu-button-modal-dialog
?
@bmuenzenmeyer -
That also works in PL/PHP but it's not by conscious design. It Just Happens to Work(tm). The pattern partials will end up sucking because this level of nesting is asking for collisions but... it appears to be supported.
Hey guys. I found my mistake. @bmuenzenmeyer You were right to address the migrating process as source of the error @dmolsen Your tip to look for the patternlab-pattern.min.js pushed me in the right direction
When i was migrating from PL/Net to the node-Version i was copying my patterns and changed the metas position from inside _patters/00-atoms/00-meta to the source/_meta folder. I have copied my own css/js in the head/foot file. Apparently I was inattentive when I copied my js in the foot section, because i was overriding the {{{ patternLabFoot }}} with the old {{{ pattern-lab-food }}}. So the patternLabFoot import was missing and patternlab-pattern.min.js and scriptloader were not included. I'm sorry for troubling you with that guys. I really tried a lot myself before I was putting my question here, but it is a really tricky error, since I wouldn't get any error messages and the inactive top-menu was the only obvious result. Thx anyway, for your constructive and dedicated help! You're doing a great job here
@mremergo glad to hear this was resolved for you. Apologies for any frustration you had. May I close this issue?
Yes, thanks, my apologies for the time you spend on it
@mremergo -
I learned something new about my system and we saw your use case. Not a waste to me :)
Hi everyone, My problem is that since I inserted my own patterns into a new patternlab-node clone, the top menu of patternlab doesn't work anymore. The pattern-structure with all subfolders is properly displayed and the link's href attributes seem to be alright. At some point of the links eventchain the redirection is stopped. I get no related console output, not in the site generation debug process nor in firebug. I can navigate just fine with altering the "p" get variable and the headline-links on the "all" page also do the job. It's just the top menu. I took out all of my own js but no improvement. I was wondering if any of you guys came across something similar before, or has an idea what could go wrong there?
@dmolsen Here I have a dump of the navItems var. As mentioned above, unfortunately there's no console output