pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

Check to make sure `comments.comments` exists #28

Closed dmolsen closed 7 years ago

dmolsen commented 8 years ago

Also make sure it doesn't equal null. Line 127 of panels-viewer.js should probably read:

if ((comments !== undefined) && (comments.comments !== undefined) && (comments.comments !== null)) {
bradfrost commented 7 years ago

Closing this out

bmuenzenmeyer commented 7 years ago

for history - since I know there is question as to why this was there somewhere in another issue - best of my recollection, it was a PL 1 to PL 2 migration that allowed for backwards compatibility