search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

Support patternengine name rather than file extension in the template tab #43

Closed geoffp closed 8 years ago

geoffp commented 8 years ago

So, this is to solve my current conundrum, which we touched on in this spec thread: https://github.com/pattern-lab/the-spec/issues/26.

When I present our library of underscore (named as .html, unfortunately) templates, we currently see this unfortunate naming of tabs:

screen shot 2016-08-22 at 11 49 22 am

And we would rather see this much more helpful naming: screen shot 2016-08-22 at 11 48 02 am

To do this, we just need to add one field, patternEngineName, to the generated patternData that gets written out onto each rendered template file. I believe we can do this in such a way that it works with both the PHP and Node engine schemes, and also in a way that's backwards compatible should that value not be present.

geoffp commented 8 years ago

PR is in for consideration.

geoffp commented 8 years ago

@bmuenzenmeyer, can we close this?

bmuenzenmeyer commented 8 years ago

I think so, yes