search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

Prefer the display of a pattern's engine name in the template tab #44

Closed geoffp closed 8 years ago

geoffp commented 8 years ago

Use patternEngineName if it's present in the patternData block, otherwise stick with patternExtension.

Addresses #43. Matching change to the Node version is in https://github.com/pattern-lab/patternlab-node/pull/447.

bmuenzenmeyer commented 8 years ago

@geoffp I really like your thorough approach and presentation of the issue here alongside the PRs. @dmolsen do you have any problem with me accepting this since your Internet is choppy?

dmolsen commented 8 years ago

if no error is thrown if patternEngineName is missing then merge. Please double-check that. I'm a little frustrated with this as a solution considering I tried hard to properly document my fix and apparently that effort was wasted if this is a real solution.

bmuenzenmeyer commented 8 years ago

I've tested this, merged it with dev and created a PR for the formal release to master with the tag to 3.3.1. I will leave it to Dave to review, tag, and push unless he defers to me.

@dmolsen your efforts were not wasted in the slightest, my understanding is that there were two issues brought up with that spec enhancement

1) info panel GETs failing because it was impossible to differentiate rendered from templated code files if they were both the same extension (hence the filename suffix) 2) info panel tabs ambiguous in the case when template and rendered code files were the same extension

Perhaps this is all extremely edge-case-y due to the reality of this particular engine (underscore), but it could be useful elsewhere too (like .handlebars vs .hbs)

dmolsen commented 8 years ago

Please release.

On Aug 25, 2016, at 1:03 AM, Brian Muenzenmeyer notifications@github.com wrote:

I've tested this, merged it with dev and created a PR for the formal release to master with the tag to 3.3.1. I will leave it to Dave to review, tag, and push unless he defers to me.

@dmolsen your efforts were not wasted in the slightest, my understanding is that there were two issues brought up with that spec enhancement

1) info panel GETs failing because it was impossible to differentiate rendered from templated code files if they were both the same extension (hence the filename suffix) 2) info panel tabs ambiguous in the case when template and rendered code files were the same extension

Perhaps this is all extremely edge-case-y due to the reality of this particular engine (underscore), but it could be useful elsewhere too (like .handlebars vs .hbs)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.