search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

add allow-modals to iframe sandbox #60

Closed thehuijb closed 6 years ago

thehuijb commented 7 years ago

To allow for components to use alert and confirm dialogs, the sandbox needs to allow-modals. Could you add this?

bmuenzenmeyer commented 7 years ago

@bradfrost @dmolsen do you see any problem with this?

bradfrost commented 7 years ago

@bmuenzenmeyer @thehuijb Nope I think it should be alright. Iframe rules have changed over the years so I don't think this was a consideration when PL was first made.

thehuijb commented 7 years ago

@bradfrost @bmuenzenmeyer thanks, keep up the great work

stevenwoodson commented 6 years ago

:+1: on this, any news on getting it merged?

bmuenzenmeyer commented 6 years ago

I'll take a look at this Friday as part of my employer-sponsored OSS time

bmuenzenmeyer commented 6 years ago

added as part of https://github.com/pattern-lab/styleguidekit-assets-default/releases/tag/v4.0.0-alpha.3