search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

Migrate away from Bower #76

Open bradfrost opened 6 years ago

bradfrost commented 6 years ago

What to do about this? https://bower.io/blog/2017/how-to-migrate-away-from-bower/

Cc @bmuenzenmeyer

bmuenzenmeyer commented 6 years ago

This factors very much into the larger scale effort. For now I'd focus on getting your design refactor done, then we can focus on some of the behind the scenes work that makes the machine run.

bradfrost commented 6 years ago

@bmuenzenmeyer Yep I figured as much. Just flagging it since I just read the post. 👍

sghoweri commented 6 years ago

@bmuenzenmeyer @bradfrost @EvanLovely FWIW, I already killed off bower in the refactor I started working on 3 months ago (in addition to chipping away at getting the JS to compile with Webpack, breaking apart the JS into more standalone modules that manage their own includes without a full JS refactor (which we really do need), getting all the JS script tags in PL to load up asynchronously without being dependent on a particular loading order, etc).

https://github.com/drupal-pattern-lab/styleguidekit-assets-default/tree/feature/modernize-patternlab-js

There's just a couple minor things that I never got around to on the Drupal Pattern Lab fork (namely just cleaning up some of the bower configs that are no longer used + reverting the hogan.js templating for the navigation since this branch also includes me getting the main PL menu to render with Twig templating](https://github.com/drupal-pattern-lab/styleguidekit-assets-default/blob/feature/modernize-patternlab-js/src/scripts/modules/layout/index.js) vs Mustache).

bmuenzenmeyer commented 6 years ago

Sounds cool @sghoweri - sounds like a trail is already blazed by your hard work !

I think a good time to tackle this is once other features settle in - this is mostly backend convenience and doesn't affect users much

sghoweri commented 6 years ago

@bmuenzenmeyer @EvanLovely trying to get my ducks in a row on this (busy week!) but for what it’s worth I think I’ve got the work needed to be done on this already figured out for a while now, just need to get the PR specific bits to this put together (and likely fold in the build tools updates at the same time given the overlapping dependencies):

https://github.com/bolt-design-system/bolt/tree/epic/v2/packages/styleguidekit-assets-bolt