search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

Deprecate classList.js #77

Closed bradfrost closed 6 years ago

bradfrost commented 6 years ago

We're currently using https://github.com/eligrey/classList.js as a polyfill for browsers that don't support element.classList.

Looking at http://caniuse.com/#feat=classlist it's safe to deprecate this.

bradfrost commented 6 years ago

I created a new branch of of feature-css-refactor that removes the classList polyfill: https://github.com/pattern-lab/styleguidekit-assets-default/commit/7f38590fa0a4bd29730cb94ad591046786ef0d5d

@bmuenzenmeyer, I know you're wheeling and dealing here, so I'll leave it to you to merge this in as you see fit.

bmuenzenmeyer commented 6 years ago

so this is ready? i sent an email with a pretty major simplifcation of work.

bradfrost commented 6 years ago

This is ready. From now on, I'll use the proper methods!

bmuenzenmeyer commented 6 years ago

closed via https://github.com/pattern-lab/styleguidekit-assets-default/releases/tag/v4.0.0-alpha.2

illycz commented 6 years ago

classList.min.js file is still linked from template: https://github.com/pattern-lab/styleguidekit-assets-default/blob/develop/src/html/index.html#L72