Additional Strange CSS Unicode Problems

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.

http://patternlab.io/

MIT License

35 stars 67 forks source link

Additional Strange CSS Unicode Problems #96

Open bmuenzenmeyer opened 6 years ago

bmuenzenmeyer commented 6 years ago

bradfrost commented 6 years ago

Very strange! The right-facing arrow makes sense, but the block-level comment shouldn't be doing that. Will take a look.

bradfrost commented 6 years ago

@bmuenzenmeyer for these changes, what branch should I be working in? I want to make sure I'm on the straight and narrow.

bmuenzenmeyer commented 6 years ago

@bradfrost branching off develop works just fine.

I tried to document this within https://github.com/pattern-lab/styleguidekit-assets-default/blob/master/.github/CONTRIBUTING.md#guidelines - let me know if you think we could improve that anywhere

bradfrost commented 6 years ago

@bmuenzenmeyer The contributing guidelines are good. I guess I'm trying to figure out if this small change would necessitate its own branch, or could that work happen right on develop? That's typically how I operate with git flow, but just want to make sure I'm following conventions.

frostyweather commented 6 years ago

@bmuenzenmeyer Is this within dist that you are seeing this? I am not seeing it on my pulled down version of this.

bmuenzenmeyer commented 6 years ago

@frostyweather yes I see it in dist. I suspect it only manifests on Windows, since you guys haven't had problems yet right?

frostyweather commented 6 years ago

@bmuenzenmeyer I have not had problems. Must be a windows thing. Maybe this sort of issue. https://stackoverflow.com/questions/44334638/css-content-character-rendering-strange

frostyweather commented 6 years ago

Changed the arrow to Unicode value in CSS within the feature-pattern-info-panel branch. Hopefully this fixes this issue