search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

maxViewPortWidth gets overwritten in styleguide.js and prevents Full view #98

Closed atu-record closed 6 years ago

atu-record commented 6 years ago

as ishViewportRange is defined by default in pattern-lab/core/config/config.yml.default on line 48

pressing the full width button in the styleguide always causes to resize maximal to 1200.

styleguide.js line 24

//alternatively, use the ishViewportRange object
if (config.ishViewportRange !== undefined) { 
    minViewportWidth = config.ishViewportRange.s[0];
    maxViewportWidth = config.ishViewportRange.l[1];
}
bmuenzenmeyer commented 6 years ago

I am having no problems with Pattern Lab Node

my config

    "ishViewportRange": {
      "s": [240, 500],
      "m": [500, 800],
      "l": [800, 2600]
    },

clicking full brings ish viewport to currentviewport

no ishMaximum defined

atu-record commented 6 years ago

@bmuenzenmeyer of course if i define the config, like you did ... it resizes to maximum vieport size. but by default i does not work. i guess i does not matter if you use node or php ... its a an styleguide.js issue

bmuenzenmeyer commented 6 years ago

fixed via https://www.npmjs.com/package/styleguidekit-assets-default 3.5.2

atu-record commented 6 years ago

seems it is not availabe via composer

bmuenzenmeyer commented 6 years ago

styleguidekit-twig-default is not a repo I was aware of until just now.

this fix was for the official cross-platform mustache assets