search

pattern-lab / styleguidekit-assets-default

The static assets for the default StyleguideKit for Pattern Lab. Contains styles and mark-up for Pattern Lab's front-end.
http://patternlab.io/
MIT License
35 stars 67 forks source link

If both ish config settings are used, use the larger value #99

Closed EvanLovely closed 6 years ago

EvanLovely commented 6 years ago

I've made a release/3.x branch and branched it off the last 3.x tagged release, v3.5.0. This PR is pointing to that branch and should become v3.5.1.

If both config.ishViewportRange and config.ishMaximum are used, then config.ishViewportRange takes precedence. This PR makes it so that if both are present, the larger one is used. I could see this being helpful if you are trying to limit the upper end of the large view to something in the area of 1200-1600px wide, but you want to be able to expand it 2000px wide when you click "Full". The current setup doesn't even allow the resize bar to move past the large size.

Relates to https://github.com/pattern-lab/patternlab-php-core/pull/131

bmuenzenmeyer commented 6 years ago

Latest release at https://www.npmjs.com/package/styleguidekit-assets-default

will port into 4.X branches too