search

pattern-lab / website

Pattern Lab's website: patternlab.io
http://patternlab.io
57 stars 33 forks source link

Long code snippets break layout in Firefox #38

Closed evoactivity closed 8 years ago

evoactivity commented 9 years ago

The overflow on the pre element doesn't work in firefox.

Issue can be seen on this page http://patternlab.io/docs/data-json-mustache.html

bradfrost commented 9 years ago

@evoactivity Thanks for bringing this to my attention. We're going to be working on a new design for the site so we will address it. Looks like adding white-space: initial fixes the issue, so I'll see if I can squeeze that in.

Thanks again!

bmuenzenmeyer commented 8 years ago

+1 to this on the dev version too. image

bradfrost commented 8 years ago

Cool we'll be looking more into code snippets and syntax highlighting with the new version. Thanks!

frostyweather commented 8 years ago

This has been addressed in the dev version by adding a max-width to the content of the page.

dap6000 commented 8 years ago

Hey @bradfrost, this is the same issue that was mis-filed (twice) over in the other repo. It looks like in the dev branch there is now a rule for max-width: 44em; for the .content selector. Line 1018 in patternlabsite/css/style.scss. I don't see a an equivalent style in the _site directory version of that file. I'm not sure if there needs to be.

Once the max-width rule make it into master and on to production you can close this issue and all the other issues that have been filed about it.

Good work @frostyweather.

bradfrost commented 8 years ago

The code overflow option has been addressed in the new design. Closing this out.