search

pattern-lab / website

Pattern Lab's website: patternlab.io
http://patternlab.io
57 stars 33 forks source link

Switch Node and PHP tabs #80

Closed bradfrost closed 6 years ago

bradfrost commented 7 years ago

Based on the direction of the project, it probably makes sense to switch the PHP and Node tabs so the Node tab is the default.

bradfrost commented 6 years ago

Closed via https://github.com/pattern-lab/website/commit/f553cad298c28a07424622ce9938b5ad7f89ae28

bmuenzenmeyer commented 6 years ago

@bradfrost I think something is amiss with this.

Take a look at a page like: http://patternlab.io/docs/installation.html

The tabs indicate Node, but the content is PHP instructions.

image

My guess is that the source order of all pages needs to swap too?

bradfrost commented 6 years ago

@bmuenzenmeyer Ah, good catch. I updated the source order of everything, but needed to change a line of JavaScript: 

$('#node').addClass('tabs__item--is-active');

In order to default to the node tab. All good now!