search

pattern-library / generator-pattern-library

Yeoman Generator creating Pattern Libraries
4 stars 4 forks source link

php errors when run by node #12

Closed scottnath closed 8 years ago

scottnath commented 8 years ago

@e2tha-e @rebmullin @sergesemashko @conortm @beynya @nikkiana

This adds PHP error responses. Please review

relates to:

sergesemashko commented 8 years ago

:+1:

scottnath commented 8 years ago

@e2tha-e @rebmullin @sergesemashko @conortm @beynya @nikkiana

any other q's? ok to merge?

e2tha-e commented 8 years ago

@scottnath I didn't take a look but I think Serge's senior enough to have push access and merge PRs. Anywho if he gives the thumbs up, it's thumbs up for me as well.

scottnath commented 8 years ago

@e2tha-e @rebmullin @sergesemashko @conortm @beynya @nikkiana

agreed. don't we have a rule against merging your own PRs though?

sergesemashko commented 8 years ago

ok, merging then