pattern-library / generator-pattern-library

Yeoman Generator creating Pattern Libraries
4 stars 4 forks source link

Minor fixes #8

Closed scottnath closed 9 years ago

scottnath commented 9 years ago

@e2tha-e @rebmullin @sergesemashko @conortm @gvorbeck @beynya @nikkiana

This is a new version which incorporates the cloning function from plutilities

In this pull request

Once this is complete, I will publish the changes to NPM and the cloning feature will be available for you to use.

e2tha-e commented 9 years ago

@scottnath Doesn't work with the latest changes to pattern library utilities.

➜  generator-pattern-library-test git:(scottnath-minor-fixes) ✗ gulp build
module.js:338
    throw err;
    ^

Error: Cannot find module 'minimist'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/Hyunho/Sites/PatternLibrary/generator-pattern-library-test/node_modules/pattern-library-utilities/lib/gulp-tasks/clone.js:12:16)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
scottnath commented 9 years ago

minimist wasn't in package.json for plutils. Please try again @e2tha-e cc: @conortm

@rebmullin @gvorbeck @nikkiana You three are actively working on using this generator. Can you please check the README and let me know if those instructions are clear and if anything is missing?

gvorbeck commented 9 years ago

readme looks pretty good. :+1:

e2tha-e commented 9 years ago

@scottnath Works now. :+1: Merging