search

pattern3 / pattern

Goal: make Pattern compatible with Python 3.
http://www.clips.ua.ac.be/pages/pattern
BSD 3-Clause "New" or "Revised" License
59 stars 35 forks source link

Update pattern3 with pattern changes (since forking) #18

Closed hayd closed 9 years ago

hayd commented 9 years ago

This includes a merge conflict resolution commit cc @tom-de-smedt .

The build failure on travis appears to be unrelated (i.e. master is now failing)

this commit: https://travis-ci.org/hayd/pattern/builds/57594529 master: https://travis-ci.org/hayd/pattern/builds/57594297

Also there's a SearchEngineLimitError, which is new!

hayd commented 9 years ago

Ah ha, it looks like there are some non-ascii characters in some of the example files, which explains a couple of the errors. But there may be one or two legitimate (new/intermittent) failures.

hayd commented 9 years ago

Note: the two tests are:

nosetests test/test_web.py:TestDOM.test_selector test/test_web.py:TestSearchEngine.test_wikipedia_article_sections

I think the selector (and perhaps these are both selector tests) is caused by this merge (and the additional regex pass)... this breaks the .class selector.

hayd commented 9 years ago

Test are "mostly" passing so going to go ahead and merge this.

Travis is green but some tests had to be skipped, specifically some HTTP301 (authentication) and test selectors (it seems like this act differently with classes in an update to whichever lib?). We should get as many of these as possible not skipping...