search

patternfly-yew / patternfly-yew-quickstart

A Patternfly for Yew quickstart repository
https://patternfly-yew.github.io/patternfly-yew-quickstart/
Apache License 2.0
28 stars 13 forks source link

Add hint examples #18

Closed phill-85 closed 1 year ago

phill-85 commented 1 year ago

Examples copied from the paternfly site. Hope this is ok?

phill-85 commented 1 year ago

I would just ask you to keep the Cargo.lock file. As this is an application, cloning it should default to using the same versions as committed and tested.

Unless there's another good reason not to do this.

I was using a local copy of paternfly-yew as the hint changes are not part of the revision patched in Cargo.toml, so the lock file changed and was adding noise to a diff.

I guess as Carog.toml patches paternfly-yew to a specific revision the code will fail as the hint component is not in that revision. How do you deal with this?

ctron commented 1 year ago

Normally you replace the rev field with the new commit SHA, once it is pushed to the main branch.

phill-85 commented 1 year ago

This should be good to go!

ctron commented 1 year ago

Merged, thanks for the PR!