search

patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
123 stars 90 forks source link

pfFilter Enhancements #472

Open dtaylor113 opened 7 years ago

dtaylor113 commented 7 years ago

Recently in OpenShift Origin Catalog/Console we had to customize the pfFilter directive:

image

Changes/Enhancements:

  1. Change the result label from "Active filters:" to "Active Filters:" (capital "F")
  2. Change the result label from "n Results" to "n of m items"
  3. Disable the filter input field if there is only 1 (original) item available
  4. We would've liked to hide the 'n items' results label when there were no active filters, but doing so caused the label to briefly appear, then disappear (flickering).
  5. Moved the filter results label, tags, 'Clear All' link to same line as the filter selection and input fields (inline mode).

These enhancements need to be vetted by PatternFly designers: Design Doc

cshinn commented 6 years ago

This looks like good stuff. I checked on the terminology guidelines and it looks like "Items" should be capitalized in #2. Ideally, that message would be variable so it could be set to "3 of 40 Hosts" or something like that if we knew exactly what was being filtered. I think it's fine to leave the "n Items" label on the page when no filters are active. It's good information to have. @beanh66 what are your thoughts?