patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
122 stars 90 forks source link

Update LESS to PatternFly core #676

Open dtaylor113 opened 7 years ago

dtaylor113 commented 7 years ago

Move as much angluar-patternfly LESS files into PatternFly core. Determine why we needed the less files in a-pf and if we could add those settings to PF core less files. which ones make sense? Is it because PF core doesn’t have the feature or because A-PF structured NEEDS to be different.

This is also important to reduce LESS usage in angular-patternfly because going forward we also need to support SASS, so the less css in angular-patternfly the better. Ideally, it should all be in PF core.

There are currently 12 less files in angular-patternfly which are canidates:

@import "misc.less";
@import "../src/card/card.less";           <--- Aimee
@import "../src/charts/charts.less";       <--- Dave
@import "../src/views/views.less";
@import "../src/toolbars/toolbars.less";
@import "../src/filters/filters.less";
      Need to match core filter less:  https://github.com/patternfly/patternfly/pull/894
@import "../src/sort/sort.less";
@import "../src/notification/notification.less";
@import "../src/views/listview/list-view.less";
@import "../src/table/table.less";
@import "../src/wizard/wizard.less";
@import "../src/pagination/pagination.less";

Unique to A-PF. PF core doesn't have these components:

@import "../src/canvas-view/canvas/canvas.less";
@import "../src/canvas-view/canvas-editor/canvas-editor.less";