search

patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
122 stars 90 forks source link

Add LESS-to-SASS Converter #688

Closed dtaylor113 closed 6 years ago

dtaylor113 commented 6 years ago

https://www.npmjs.com/package/grunt-lassie

dtaylor113 commented 6 years ago

Hi @jeff-phillips-18, @amarie401, @TheRealJon ,

I've added 'lessToSass' and 'sass' tasks to angular-patternfly. The resulting sass-2-css is almost identical to the original (less-2-css): https://www.diffnow.com/?report=jh54y

@TheRealJon, wondering if all these rules are necessary?

Results in a dist/sass directory. Still have to add the grunt build --sass feature to angular-patternfly.

TheRealJon commented 6 years ago

@dtaylor113 All of them should not be necessary. There are a few that are specific to Ruby related tooling and also specific to the patternfly core repo. Once you submit a PR, I can comment on which rules are unnecessary, or I can submit a PR to your fork if you want.

Also, check the latest from master on patternfly/patternfly. A PR was just merged that fixed a conversion rule.

TheRealJon commented 6 years ago

As you may have noticed, I am the publisher of that grunt-lassie package. I forked an existing and abandoned converter (grunt-less-to-sass) and published it so that we can update it if we need to. Some of these conversion rules could be added to that tool so that we don't need to copy/paste rules between projects.

dtaylor113 commented 6 years ago

Thanks @TheRealJon, Either way works for me. Feel free to post PR to my branch, or when I'm ready we can handle unneeded rules via PR comments. -thanks

TheRealJon commented 6 years ago

@dtaylor113 This PR should remove all the unneeded rules: https://github.com/dtaylor113/angular-patternfly/pull/5

dtaylor113 commented 6 years ago

Thanks @TheRealJon !