patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
122 stars 90 forks source link

Tree List View with Multi-Child Expansion - Angular 1.x implementation not available #702

Open pulgupta opened 6 years ago

pulgupta commented 6 years ago

Hi Team,

We are using patternfly to develop a full fledged application for which we need to show our org hierarchy. We zeroed down to "Tree List View with Multi-Child Expansion" component for this purpose. http://www.patternfly.org/pattern-library/content-views/tree-list-view/

However I checked and the Angular 1.x implementation is missing. Can you please prioritize and implement the same. Also can you please provide a rough estimate by when this will be available.

Regards, Pulkit

dtaylor113 commented 6 years ago

Hi @pulgupta, thank you for filing this issue, it's great to get feedback/input from the community!

Are you working on a Red Hat application? If so, which team? -thanks!

Unfortunately, it looks like there isn't any patternfly core HTML or CSS for Tree List view. We will bring up your request to the Patternfly Core team so they may prioritize based on their ongoing work. Once we have patternfly core HTML and CSS, we can prioritize implementing the Angular 1.x component in angular-patternfly.

If you wish to speed up the process, it would be great if you could work on, and contribute back, an angular-patternfly Tree List View component. This way we can work with the PatternFly Core team to validate the HTML and CSS, and the angular-patternfly team to fast-track its adoption. I imaging Tree List View will be an extension of the "Compound Expansion" for https://www.patternfly.org/angular-patternfly/#/api/patternfly.views.component:pfListView#example_demo

Thanks, Dave

dtaylor113 commented 6 years ago

Actually, it would probably be based on an extension of "Expanding Rows" for pfListView (see checkbox under the example)

pulgupta commented 6 years ago

Hi @dtaylor113, thanks for prioritizing it. Yes I am working on a Red Hat application within ADS team in IT.

beanh66 commented 6 years ago

@dtaylor113 It sounds like the support for this in PF core does already exist, per a comment from @LHinson on https://github.com/patternfly/patternfly/issues/950. Can we move this over to the "Next to Do" column on the project board? Thanks!

dtaylor113 commented 6 years ago

Hi @beanh66, I still do not see where I can get the pf 'core' HTML, CSS/LSS for 'Tree List View with Multi-Child Expansion'?

LHinson commented 6 years ago

@dtaylor113 we don't have the specific example coded in core to display on that page. That said pf-list [1] is flexible and supports the nested rows. If this is urgent and you cannot wait on core, I've asked @matthewcarleton to help give you some pointers on how to nest them from a core perspective. My hope is that this guidance plus viewing the patternfly-ng example [2], will give you the information that you need to proceed. Please let us know when you would be looking to implement this in angular-pf so we know when we need to provide this guidance by.

We have a number of issues and priorities that are ahead of this one from a core perspective. @matthewcarleton and I will be working on the core github board today to help clean that up and communicate to the community the current priorities and when you might expect things like the tree list view to be introduce to core.

Thanks and let me know if you have any questions on this!

[1] https://rawgit.com/patternfly/patternfly/master-dist/dist/tests/list-pf.html [2] https://rawgit.com/patternfly/patternfly-ng/master-dist/dist-demo/index.html#/treelist

dtaylor113 commented 6 years ago

Hi @LHinson, ok sounds reasonable. We can work on creating the HTML/CSS and contributing it back to PF core. It would be great if @matthewcarleton could give us some initial direction. I'm not sure when we will be starting this, it is in our backlog at the moment.

LHinson commented 6 years ago

@dtaylor113 thanks! We can can cover the core example, just wanted to make sure you knew that you weren't blocked on angular-pf!

dtaylor113 commented 6 years ago

https://github.com/patternfly/patternfly/pull/980