patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
122 stars 90 forks source link

fix(donut-pct-chart): Add tooltip attribute #705

Closed TheRealJon closed 6 years ago

TheRealJon commented 6 years ago

Description

Add a tooltip attribute to the donut-pct-chart component which allows for a selection between 3 preset tooltip formats: Fixes https://github.com/patternfly/angular-patternfly/issues/671

Screen Shots

Percent Format tooltip = 'percent' (default)

image

Amount Format tooltip = 'amount'

image

Both Format tooltip = 'both'

image

PR Checklist

beanh66 commented 6 years ago

@TheRealJon Thanks, the percent format and the amount format look great. I was wondering if we could make a small adjustment to the format with both. I noticed in the PF Design it shows both with a gap between, something like this: donut Is it possible to make this change to be more consistent? I attached the design example for reference as well.

screen shot 2018-01-29 at 8 07 31 am
TheRealJon commented 6 years ago

@beanh66 I adjusted the format to match your screen shot:

image

TheRealJon commented 6 years ago

@dtaylor113 @beanh66 Could you approve again? I just added some unit tests for the tooltip.