Closed jcaianirh closed 6 years ago
In Table View, the 'no items match filter' empty state is wider than the toolbar:
Made requested updates by @dtaylor113
Hi @cshinn, @beanh66, this PR updates a angular-patternfly example which shows a core patternfly 'pattern' -List/Card/Table view with 'no results match' empty state. It would be great to get designer/styling feedback -thanks
@dtaylor113 Interestingly we also just got something similar updated in the design repo here https://github.com/patternfly/patternfly-design/pull/567
So I think if we want to be consistent, it would need to say "No Results Match the Filter Criteria" (no period needed). @cshinn do you agree?
@jcaianirh could you remove the period and provide an updated screenshot? Thanks!
@amarie401 @beanh66 fixed capitalization, and removed the period for 'No Results Match the Filter Criteria' title string. Updated screenshot as well.
Hmm...according to @beanh66 latest design spec, think the link needs to be 'Clear All Filters'
Ahhh you're right, good catch @dtaylor113.
@dtaylor113 @amarie401 Thanks for the input. I updated the link text to 'Clear All Filters', and the commit message and pr message to use the chore indicator keyword because there is no effect on consumers.
Description
Fix Issue https://github.com/patternfly/angular-patternfly/issues/693 Add an empty state div with the messaging for 0 filtered results to differentiate that of an actual empty set based on the patternfly docs listed in the issue.
Before:
After:
PR Checklist