patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
122 stars 90 forks source link

chore(pfToolbar): updated ngdoc with 'no filter results' empty state instead of 'No Items Available' #714

Closed jcaianirh closed 6 years ago

jcaianirh commented 6 years ago

Description

Fix Issue https://github.com/patternfly/angular-patternfly/issues/693 Add an empty state div with the messaging for 0 filtered results to differentiate that of an actual empty set based on the patternfly docs listed in the issue.

Before:

before

After:

after2

PR Checklist

dtaylor113 commented 6 years ago

In Table View, the 'no items match filter' empty state is wider than the toolbar:

image

jcaianirh commented 6 years ago

Made requested updates by @dtaylor113

dtaylor113 commented 6 years ago

Hi @cshinn, @beanh66, this PR updates a angular-patternfly example which shows a core patternfly 'pattern' -List/Card/Table view with 'no results match' empty state. It would be great to get designer/styling feedback -thanks

beanh66 commented 6 years ago

@dtaylor113 Interestingly we also just got something similar updated in the design repo here https://github.com/patternfly/patternfly-design/pull/567

screen shot 2018-02-14 at 2 26 45 pm

So I think if we want to be consistent, it would need to say "No Results Match the Filter Criteria" (no period needed). @cshinn do you agree?

amarie401 commented 6 years ago

@jcaianirh could you remove the period and provide an updated screenshot? Thanks!

jcaianirh commented 6 years ago

@amarie401 @beanh66 fixed capitalization, and removed the period for 'No Results Match the Filter Criteria' title string. Updated screenshot as well.

dtaylor113 commented 6 years ago

Hmm...according to @beanh66 latest design spec, think the link needs to be 'Clear All Filters'

amarie401 commented 6 years ago

Ahhh you're right, good catch @dtaylor113.

jcaianirh commented 6 years ago

@dtaylor113 @amarie401 Thanks for the input. I updated the link text to 'Clear All Filters', and the commit message and pr message to use the chore indicator keyword because there is no effect on consumers.