patternfly / angular-patternfly

This repo contains instructions and the code for a set of Angular 1 components for the PatternFly project.
http://www.patternfly.org/angular-patternfly/
MIT License
123 stars 90 forks source link

pfVerticalNavigation: on mobile, move the masthead utility items to the vertical navigation #747

Closed dtaylor113 closed 6 years ago

dtaylor113 commented 6 years ago

Description

Added a mobileOnly property to nav. item objects; when 'true' items only display in mobile mode. Addresses: #745

Ex: The Help and User vert. nav items only appear when in mobile (< 768px) mode, and are hidden when not in mobile mode: mobileonly

Note the masthead utility items (Help & User dropdowns) continue to be hidden at mobile; this PR allows app devs to mimic them 'moving' to the vert nav menu.

@alexkieling

PR Checklist

dtaylor113 commented 6 years ago

Hi @jeff-phillips-18, I believe I have addressed your comments, except the one about the Help-at-mobile menu, IMO I think leaving off the 'About' menu item represents a truer @mobile menu.

dtaylor113 commented 6 years ago

Might want to address #746 while you are working here...

I'd prefer to do that in a follow up pr, thanks :-)