patternfly / design-tokens

MIT License
1 stars 8 forks source link

feat(export): Add correct names for charts token files #38

Closed wise-king-sullyman closed 6 months ago

wise-king-sullyman commented 6 months ago

Closes #15

mfrances17 commented 6 months ago

Looks good AFAICT! Once merged, will this automatically work from figma without any additional steps? @mfrances17 ?

The plugin will always export all variables but anytime you add a new set of variables it will need to be updated; it needs to handle where it needs to separate the file and the new file name(s) to which to save.

No additional steps needed, but assuming the new charts json files follow the same model as the existing ones, the instructions in the readme should be updated to include charts.json and charts.dark.json in steps 4i and 4ii, respectively. @wise-king-sullyman

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: