patternfly / design-tokens

MIT License
1 stars 8 forks source link

Add token(s) for text-decoration/underline #40

Closed mcoker closed 3 months ago

mcoker commented 8 months ago

We are underlining some things in penta, and should add some tokens for that. Primarily what we're setting is:

cc @lboehling

github-actions[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

lboehling commented 3 months ago

Hey @mcoker! i added text decoration tokens in this figma branch

Here is a quick overview of the tokens I added:

Base Tokens

Screenshot 2024-06-06 at 1 58 58 PM

Semantic Tokens

Width/Offset tokens

Screenshot 2024-06-06 at 1 58 08 PM

Help text tokens

Screenshot 2024-06-06 at 1 58 40 PM

Link tokens

Screenshot 2024-06-06 at 1 58 28 PM

Editable text tokens

Screenshot 2024-06-06 at 1 58 22 PM

I didn't add specific tokens for color because I think we previously discussed the underlines inheriting the text color. I can add specific color tokens, too, if you feel we need them!

lboehling commented 3 months ago

hey @mcoker if these look alright, i can merge this branch before I'm out!

mcoker commented 3 months ago

@lboehling these lgtm. One change is --line--200: underlined should just be underline (present tense).

re: colors, I'd say if you want that to be a themable part of PF, we can add them. Otherwise we can add later if the use case comes up 👍

lboehling commented 3 months ago

i think we can add the colors later if the use case comes up! these tokens are in figma now :)