Transform certain dimension values to REM instead of PX - Githubissues

patternfly / design-tokens

MIT License

1 stars 8 forks source link

Transform certain dimension values to REM instead of PX #47

Closed srambach closed 4 months ago

srambach commented 6 months ago

Background: https://github.com/patternfly/patternfly/issues/6123#issuecomment-2098388758

We'd like to

transform the values that are coming from Figma as pixel values into rems instead.
ideally, the factor for translating px to rem is pulled from a token
some things should scale (so should be rems) but others should not -
Rems: fonts, spacers
Px: border, border radius, breakpoints?

Here's where we are using a custom transform to put pixels on certain things: https://github.com/patternfly/design-tokens/blob/main/packages/module/build.js#L24

Style dictionary has a transform we might be able to use: https://amzn.github.io/style-dictionary/#/transforms?id=sizepxtorem

github-actions[bot] commented 4 months ago

:tada: This issue has been resolved in version 1.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: