search

patternfly / design-tokens

MIT License
1 stars 8 forks source link

Charts tokens - dupes in dark CSS #53

Open mcoker opened 4 months ago

mcoker commented 4 months ago

Looks like all of the charts tokens are output again in tokens-charts-dark.scss, not just the tokens that are different for dark theme compared to tokens-charts.scss. Shouldn't the dark stylesheet only include necessary overrides to the default tokens?

srambach commented 4 months ago

I agree, the dark charts stylesheet should only include the overrides.

At a glance, it seems to be something with the structure of the collection in figma and/or the exporter - the dark charts tokens aren't coming with 'dark' as a layer.

Once that's done, the dark charts config might also need to look for charts.dark instead of just charts